-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include Twitter card meta tags #117
Conversation
Yeah, I was in doubt about that. It is a required tag, and you don't have access to the author's Twitter username. So I just decided to go with |
Maybe we could do an include of twitter card if there is a Right now you can customize the description used, the published at date, and if we added this, the ability to add a twitter card and twitter username. |
I think it's safe to say people might not like us generating Twitter cards citing Tighten without their knowledge, so while I appreciate this PR, I think @JacobBennett is right--we need to let them set it or not show it at all. I would love a PR that does what Jacob describes: sends the Twitter card if they have a gistlog config setting assigning their Twitter username. What do you think @sailingdeveloper? Thanks!! |
That would work, but you'd have to enter it for every Gistlog, right? That wouldn't be ideal for users that make use of the landing page/user blog feature... |
@sailingdeveloper Geez, you're right. I was thinking we had a global configuration option for Gistlog. Does this not exist? Have I lost my mind? |
Have we ever thought of having a global |
Yeah @mattstauffer I don't believe we have something like that. Not that I am aware of. |
Would you store it with one of the gistlogs, or create a seperate gist? |
separate gist I would think. That way you could have your defaults, then individual blog posts could override the defaults. |
This is literally the only "documentation" we have on using Gistlog Landing Pages |
You could also use this to provide a description of your blog, or a cover image etc. |
We've definitely talked about having global settings, but I guess that up until now we've been able to survive without it. However, I think this would actually do better as in-database settings in Gistlog instead of a Gist. Making people manually enter keys and values in a random gist file seems like a less-than-desireable user experience. |
Are you working on a Gistlog account with user settings? |
We would have to introduce the idea. Right now, we do have a users table for every user, but we don't have an sort of settings page--that we would have to create. |
All right. Let me know if you need any help, I'd be happy to contribute 🙂 |
... For some reason GitHub won't let me change the target branch! This is not really closed. |
Title says it all :)