Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include Twitter card meta tags #117

Closed
wants to merge 1 commit into from

Conversation

sailingdeveloper
Copy link

@sailingdeveloper sailingdeveloper commented Feb 6, 2017

Title says it all :)

@JacobBennett
Copy link
Contributor

does it seem weird that the twitter::site would always be attributed to tightenco?

image

@sailingdeveloper
Copy link
Author

Yeah, I was in doubt about that. It is a required tag, and you don't have access to the author's Twitter username. So I just decided to go with tightenco for lack of a better option.
Using the author's Github username and assuming its Twitter username is the same is not desirable either.

@JacobBennett
Copy link
Contributor

Maybe we could do an include of twitter card if there is a twitter_username piece in the gistlog.yml file attached to the gist? We need better documentation around these sorts of little tweaks available to authors through the use of the gistlog.yml file.

Right now you can customize the description used, the published at date, and if we added this, the ability to add a twitter card and twitter username.

@mattstauffer
Copy link
Member

I think it's safe to say people might not like us generating Twitter cards citing Tighten without their knowledge, so while I appreciate this PR, I think @JacobBennett is right--we need to let them set it or not show it at all.

I would love a PR that does what Jacob describes: sends the Twitter card if they have a gistlog config setting assigning their Twitter username. What do you think @sailingdeveloper?

Thanks!!

@sailingdeveloper
Copy link
Author

That would work, but you'd have to enter it for every Gistlog, right? That wouldn't be ideal for users that make use of the landing page/user blog feature...

@mattstauffer
Copy link
Member

@sailingdeveloper Geez, you're right. I was thinking we had a global configuration option for Gistlog. Does this not exist? Have I lost my mind?

@JacobBennett
Copy link
Contributor

Have we ever thought of having a global gistlog.yml file? Something like gistlog_config.yml that could have settings across all of your gistlogs? Individual gistlog.yml files on the blog would override defaults set in the gistlog_config.yml... or since we are using the word defaults just call it gistlog_defaults.yml

@JacobBennett
Copy link
Contributor

Yeah @mattstauffer I don't believe we have something like that. Not that I am aware of.

@sailingdeveloper
Copy link
Author

Would you store it with one of the gistlogs, or create a seperate gist?

@JacobBennett
Copy link
Contributor

separate gist I would think. That way you could have your defaults, then individual blog posts could override the defaults.

@JacobBennett
Copy link
Contributor

This is literally the only "documentation" we have on using Gistlog Landing Pages

https://gistlog.co/mattstauffer/a82db51468a02f53442d

@sailingdeveloper
Copy link
Author

You could also use this to provide a description of your blog, or a cover image etc.

@mattstauffer
Copy link
Member

We've definitely talked about having global settings, but I guess that up until now we've been able to survive without it.

However, I think this would actually do better as in-database settings in Gistlog instead of a Gist. Making people manually enter keys and values in a random gist file seems like a less-than-desireable user experience.

@sailingdeveloper
Copy link
Author

Are you working on a Gistlog account with user settings?

@mattstauffer
Copy link
Member

We would have to introduce the idea. Right now, we do have a users table for every user, but we don't have an sort of settings page--that we would have to create.

@sailingdeveloper
Copy link
Author

All right. Let me know if you need any help, I'd be happy to contribute 🙂

@mattstauffer
Copy link
Member

... For some reason GitHub won't let me change the target branch! This is not really closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants