Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Customers Listing Page #33

Merged
merged 6 commits into from
Aug 18, 2021
Merged

Add Customers Listing Page #33

merged 6 commits into from
Aug 18, 2021

Conversation

faxblaster
Copy link
Contributor

Adds a simple listing page and navigation item for Customers. Also includes a minor refactor of pagination to make it easier to use across multiple components. Fixes some formatting with prettier.

Screen Shot 2021-07-21 at 8 58 49 AM

@faxblaster
Copy link
Contributor Author

Leaving in draft until we can merge #30 & #32.

@faxblaster faxblaster marked this pull request as ready for review August 17, 2021 12:08
Copy link
Member

@mattstauffer mattstauffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Only one requested change

resources/js/components/CustomersTable.vue Show resolved Hide resolved
@@ -1,6 +1,6 @@
<template>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, easy refactor. Nice work!

@faxblaster faxblaster merged commit d251b6e into main Aug 18, 2021
@faxblaster faxblaster deleted the alk/add-customers-listing branch August 18, 2021 22:11
@faxblaster faxblaster linked an issue Aug 19, 2021 that may be closed by this pull request
@faxblaster faxblaster mentioned this pull request Oct 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add customer index page
2 participants