Adds test coverage for commands and project api routes #275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ses coverage from 34.1% -> 45.7%.
…reases coverage from 45.7% -> 52.2%.
- Swap the withoutWrapping call in favor of setting the static property wrap. Calling self::withoutWrapping will remove the data wrapper for ALL json resources, not just the ProjectResource used in the web routes.
|
So it looks like the secrets from a forked repo can't be used when running the test action here... would love a hand to see the best way to get this to green. |
|
Updated the PR with the latest changes from #276 and we are indeed green here! Thanks so much for making that change to get this PR through! |
|
Hey @driftingly - just as a reminder, I don't have write access so feel free to merge when you're ready :) |
|
Thanks again for all the help here! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the following test cases:
Commands:
CreateProjectSnapshotsTestFetchGitHubProjectsTestFetchProjectStatsTestOutputStatsTestSendStatsToSlackTestAPI routes:
GetProjectsTestShowProjectTestAlso makes some minor changes:
CachedProjectList.FetchProjectStatsto make it easier to assert their values when testing.ProjectResourcebecause the previous approach actually removes wrapping fromJsonResourceaffecting all json resources.getKey()method on theOrgSlacknotifiable to allow testing usingNotification::fake().All test cases passing with these changes and linter is green. Happy to make any changes that you see fit in order to get this merged.