Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge child class fillable traits with those of the parent class #120

Merged
merged 3 commits into from
Jan 12, 2024

Conversation

gcavanunez
Copy link
Contributor

@gcavanunez gcavanunez commented Nov 7, 2023

Highlights

  • merges fillable arrays on child with parent fillable
  • add dedicated tests for this behavior

References

@gcavanunez gcavanunez changed the title DRAFT - feat: merging fillable traits feat: merging fillable traits Nov 8, 2023
@gcavanunez gcavanunez marked this pull request as ready for review November 8, 2023 00:38
Copy link
Member

@mattstauffer mattstauffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great code; just a few code style notes, which I think we can solve in the future by running Duster on the codebase and then using that for future code style.



/**
* Merge the fillable attributes for the model with Parent Class
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Merge the fillable attributes for the model with Parent Class
* Merge the fillable attributes for the model with those of its Parent Class

*/
public function getFillable()
{

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete this extra line please.

src/HasParent.php Show resolved Hide resolved
src/HasParent.php Show resolved Hide resolved
tests/Models/Conference.php Show resolved Hide resolved
tests/Models/Event.php Outdated Show resolved Hide resolved
tests/Models/Workshop.php Show resolved Hide resolved
@mattstauffer mattstauffer changed the title feat: merging fillable traits Merge child class fillable traits with those of the parent class Nov 9, 2023
@driftingly driftingly merged commit f92d949 into main Jan 12, 2024
10 checks passed
@driftingly driftingly deleted the feat/fillable-trait branch January 12, 2024 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants