Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docker.elastic.co support for elasticsearch images #119

Merged
merged 7 commits into from
Oct 24, 2020

Conversation

danielebarbaro
Copy link
Contributor

Hi!
This PR solve #76 .

Official elasticsearch images are in https://www.docker.elastic.co/r/elasticsearch.
The problem was that https://docker.elastic.co/v2/elasticsearch/elasticsearch/tags/list needs an access_token.

I wrote some lines of code to catch a valid access_token before call tag list url.

@abenerd
Copy link
Contributor

abenerd commented Sep 16, 2020

This looks great!
Do you know how long the access token is valid for? Maybe if it is for long enough we could cache it for a time so we don't have to request it always.

@danielebarbaro
Copy link
Contributor Author

Hi @abenettt, unfortunately there's no expire_in field on auth response.

I've been thinking about saving the token somewhere but you need to take a valid token only when you create a new container.

@abenerd
Copy link
Contributor

abenerd commented Sep 16, 2020

Ah yeah you're right it would not really make sense to save the token.

@danielebarbaro
Copy link
Contributor Author

hi, @josecanhelp @mattstauffer I just updated the PR just to keep branch cleaned. Feel free to discard this PR

@josecanhelp josecanhelp merged commit 6bf6be5 into tighten:main Oct 24, 2020
@josecanhelp
Copy link
Contributor

Great work, @danielebarbaro. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants