Verify if a volume is active. #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think the second screenshot's behavior is the target of #89, so we can ignore that for this PR. Reviewing the rest of the PR now. Thanks! |
mattstauffer
requested changes
Sep 26, 2020
Co-authored-by: Sara Bine <sara@tighten.co>
|
Hi @mattstauffer , thanks for your review. A made some review and a merge main in my branch to avoid conflicts. |
|
Hi @mattstauffer now PR is updated. This PR needs #157 . |
|
@danielebarbaro Great--taking a look now. Thanks! |
|
Looks great. Thanks so much @danielebarbaro! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @mattstauffer , this maybe solve #123 .
I used "maybe" because I've a doubt.
At the moment I checked with
docker ps -a --filter volume=volume_namethat a volume exist and the result is:So when user chose an existing container takeout return an error until user chose a unique name container.
Do you want to handle ,in some way, also this behaviour?