-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using --default option #133
Conversation
@mattstauffer all tests pass on local. |
@khanalpride Thanks so much for this PR. I'm still working through a few adjustments I'd like to make. Mainly, I was hoping to use a Great work! |
@josecanhelp sure. |
@josecanhelp I am still trying to find way for May be @nunomaduro can provide some clue regarding |
@josecanhelp just added --all to disable command |
@josecanhelp @mattstauffer |
Hey @khanalpride sorry for the delay. I am still considering this PR, but I just haven't had the time to review it. I will update you soon. Thanks again for this work! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had a few requests, but this is really great work! I can't wait to get it merged in and deployed.
Thank you.
@josecanhelp I have checked and reviewed your suggestion. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Again, great work on this! 👏
I have worked out on using --default on any enable command to use default ports and tags or keys
can be useful if you create many services at once as per your project setup
#130
I have edited the Environment.php to check ports availability on Linux and WSL
And I have edited the container name, so that it will not conflict when creating 2 docker container with same version but with different ports