-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Group the services list by categories #135
Group the services list by categories #135
Conversation
Hi @mattstauffer, thanks for your review. A made some review and a merge main in my branch to avoid conflicts. |
@@ -47,7 +59,20 @@ public function enableableServices(): array | |||
})->toArray(); | |||
} | |||
|
|||
public function enable(string $service): void | |||
public function enableableServicesByCategory(): array |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One last request! Can we sort the list after we're done so the category list is alphabetized?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Category sorted. 💪
I like it! Thanks @danielebarbaro! I'll let a few folks try it out before we tag a release. |
This PR solve #88 88