-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for EventStoreDB #154
Conversation
morrislaptop
commented
Oct 5, 2020
- some small fixes in the test class
@morrislaptop would you mind modifying this PR to allow me to make edits? I made some changes locally I'd like to push up; I'd like to push the changes up and then ask you to take a look at the failing tests. Thanks! |
@mattstauffer it was already checked but i've unchecked and checked it, does that work? |
@morrislaptop Hm, nope, not sure why it isn't. Let me just throw you a patch file quickly. |
Uh... I merged main in and pushed, which should've done almost nothing, and instead it's.. doing this? I'm not sure what's going on. :/ |
lol! Give me 5, I'll merge master in, there was only conflict on README IIRC |
9eff8d9
to
ba71a00
Compare
# Conflicts: # README.md
Thanks @morrislaptop! OK, so now where we are right now, we have two tests failures; would you mind taking a look? |
@mattstauffer Tests and style fixed 👍 |
Thanks @morrislaptop! |