Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for EventStoreDB #154

Merged
merged 11 commits into from
Dec 1, 2020
Merged

Conversation

morrislaptop
Copy link
Contributor

  • some small fixes in the test class

@mattstauffer
Copy link
Member

@morrislaptop would you mind modifying this PR to allow me to make edits? I made some changes locally I'd like to push up; I'd like to push the changes up and then ask you to take a look at the failing tests.

Thanks!

@morrislaptop
Copy link
Contributor Author

@mattstauffer it was already checked but i've unchecked and checked it, does that work?

@mattstauffer
Copy link
Member

@morrislaptop Hm, nope, not sure why it isn't. Let me just throw you a patch file quickly.

@mattstauffer
Copy link
Member

Uh... I merged main in and pushed, which should've done almost nothing, and instead it's.. doing this? I'm not sure what's going on. :/

@morrislaptop
Copy link
Contributor Author

lol! Give me 5, I'll merge master in, there was only conflict on README IIRC

# Conflicts:
#	README.md
@mattstauffer
Copy link
Member

Thanks @morrislaptop! OK, so now where we are right now, we have two tests failures; would you mind taking a look?

image

@morrislaptop
Copy link
Contributor Author

@mattstauffer Tests and style fixed 👍

@mattstauffer mattstauffer merged commit 53422c8 into tighten:main Dec 1, 2020
@mattstauffer
Copy link
Member

Thanks @morrislaptop!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants