Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add container log command. #183

Merged
merged 4 commits into from
Dec 4, 2020

Conversation

danielebarbaro
Copy link
Contributor

For lazy people a new log command.

@danielebarbaro
Copy link
Contributor Author

🙋🏻‍♂️

Copy link
Member

@mattstauffer mattstauffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Just a few questions

$container = $this->argument('containerId');

if (! $container) {
$this->error("Please insert a valid container ID.\n");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
$this->error("Please insert a valid container ID.\n");
$this->error("Please pass a valid container ID.\n");

app/Commands/LogCommand.php Show resolved Hide resolved
app/Shell/Docker.php Show resolved Hide resolved
@mattstauffer mattstauffer merged commit e7dc08a into tighten:main Dec 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants