-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow passing through additional options after the enable command #294
Conversation
E.g. takeout enable meilisearch -- --meilisearch-specific-flag-here --other-flag=great
OK, it's incomplete in part because I only am processing pass through flags that start with two dashes, so i need to write a test and fix it to also work for this: takeout enable meilisearch -- -e MEILI_MASTER_KEY='MY_KEY_HERE' |
Fixed that. |
The failing tests are a PHP version issue that we're handling elsewhere. |
@@ -40,7 +40,7 @@ | |||
| | |||
*/ | |||
|
|||
'env' => 'development', | |||
'env' => env('APP_ENV', 'development'), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This and the change in phpunit.xml.dist
are so that we can check App::environment()
/ App::runningUnitTests
/ config('app.env')
in testing.
E.g.
Closes #218