Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure Composer dependencies are compatible with PHP 8.0 #308

Merged
merged 8 commits into from
Jan 3, 2023

Conversation

tonysm
Copy link
Contributor

@tonysm tonysm commented Jan 3, 2023

Fixed

  • Fixes phar file not compatible with PHP 8.0 when pulling the Composer dependencies and building from a higher PHP version

issues #296

Copy link
Member

@driftingly driftingly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Setting platform-check to true checks php and extensions.
I was reading a bit about it here:
https://php.watch/articles/composer-platform-check

Composer v2 now creates a new vendor/composer/platform_check.php file that immediately terminates rest of the application if the current server platform does not match the original environment it was created on.

It goes on to show error messages

Composer detected issues in your platform: Your Composer dependencies require a PHP version ">= 7.3.0" and "< 7.4.0". You are running 7.4.5.

So it looks like it will work as-is now.

@tonysm tonysm merged commit e526592 into main Jan 3, 2023
@tonysm tonysm deleted the fix/tm-php-80-builds branch January 3, 2023 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants