Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Excellence #289

Merged
merged 20 commits into from May 8, 2020
Merged

Excellence #289

merged 20 commits into from May 8, 2020

Conversation

bakerkretzmar
Copy link
Collaborator

@bakerkretzmar bakerkretzmar commented May 1, 2020 •
edited

This PR brings Ziggy closer to excellence:

  • add .editorconfig
  • update .gitattributes and .gitgnore
  • un-track package-lock.json
  • update package.json and composer.json
  • update contributing.md
  • update the issue template
  • update readme.md
    • grammar and wording
    • consistent formatting
    • badges
    • Security section

mattstauffer
mattstauffer reviewed May 1, 2020
View reviewed changes
package.json Outdated Show resolved Hide resolved
@ankurk91
Copy link
Contributor

ankurk91 commented May 8, 2020 •
edited

@bakerkretzmar
What about using Github actions for testing to make it more awesome.

PS. - Ah, i just noticed, it is already there.

jakebathman
jakebathman requested changes May 8, 2020
View reviewed changes
Copy link
Collaborator

@jakebathman jakebathman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome, just one suggested change to readme and it's good to merge 👍

README.md Show resolved Hide resolved
bakerkretzmar and others added 3 commits May 8, 2020 15:48
@bakerkretzmar bakerkretzmar merged commit 1cfa5fe into master May 8, 2020
@bakerkretzmar bakerkretzmar deleted the jbk/excellence branch May 8, 2020 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattstauffer mattstauffer mattstauffer left review comments

@jakebathman jakebathman jakebathman requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bakerkretzmar @ankurk91 @jakebathman @mattstauffer