Fix '.' escaping in current()

[d13r]

No description provided.

[bakerkretzmar]

@davejamesmiller can you explain what this does and why it's necessary? Thanks.

[d13r]

@bakerkretzmar

From the docs:

To check whether you are currently on a specific route, you can pass the route name to current():
route().current('events.index');
// returns true

The . is not currently being escaped correctly, so events-index would also match.

Specifically in my case, it means hosting.* is compiled to ^hosting..*$ instead of hosting\..*$, so current('hosting.*') returns true for the route hosting-contacts.index as well as hosting.index and the wrong menu item is highlighted.

[d13r]

It looks like there was originally an attempt to escape it, but it didn't work correctly because '\.' === '.' in JS, and then it was auto-formatted into .replace('.', '.') which is more clearly a no-op.

[bakerkretzmar]

Wow, '.' === '\.' is truly messed up....

Thanks a lot for clarifying, and for the fix! Gonna try to merge into the 0.9.x branch so we can release it as a patch.

[bakerkretzmar]

Nope I'm not, that got very messy in git very quickly 😂 will do a patch release separately.

[d13r]

Thanks @bakerkretzmar 😃