Ensure current() method respects 'absolute' option #353
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #329 and #348 by ensuring that the
.current()
method will respect Ziggy'sabsolute
option. What this means is that now, if you setabsolute
tofalse
,.current()
will only consider the pathname when matching the current window URL.This is a pretty inelegant solution to that problem but it's technically breaking so I want to make it now. I do want to eventually add a flag to
.current()
itself to accomplish this, or find a better way, but we can add that later in a minor release.Before:
After: