Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Octane Prep #415

Merged
merged 1 commit into from Apr 2, 2021
Merged

Octane Prep #415

merged 1 commit into from Apr 2, 2021

Conversation

taylorotwell
Copy link
Contributor

This PR takes care of resetting the generator state between requests when using Laravel Octane. Otherwise, the routes will be properly generated on the first request but all subsequent requests fail.

@DanielCoulbourne
Copy link
Contributor

Taylor Otwell – Ziggy Contributor 😂 ❤️

@bakerkretzmar bakerkretzmar merged commit 58f3a2f into tighten:main Apr 2, 2021
@bakerkretzmar
Copy link
Collaborator

🏎️ 🧨

@Kocal
Copy link

Kocal commented Apr 2, 2021

What happens if Octane is not installed?

@bakerkretzmar
Copy link
Collaborator

Nothing, because the RequestReceived event will never be fired.

@Kocal
Copy link

Kocal commented Apr 2, 2021

Oh alright, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants