Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

still encode other characters in last parameter #507

Merged
merged 1 commit into from Jan 31, 2022
Merged

still encode other characters in last parameter #507

merged 1 commit into from Jan 31, 2022

Conversation

rodrigopedra
Copy link
Contributor

version 1.4.3 added the ability to use forward slashes on the last parameter when the user has configured a route to accept any value on it.

But other special characters should still be URL encoded.

This PR:

  • Use encodeURIComponent to encode other characters than / in the last parameter
  • Add a test assertion that fails without this PR's code change and passes afterwards

@bakerkretzmar bakerkretzmar merged commit b3ebdd8 into tighten:main Jan 31, 2022
@bakerkretzmar
Copy link
Collaborator

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants