Fix route().current() with encoded characters
#668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bakerkretzmar
force-pushed
the
jbk/route-current-cyrillic-fix
branch
from
1f3f659
to
cbc85a8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR decodes the window location before trying to match it against route patterns. The issue here is that a URL like
http://example.com/статистика, although it'll show up exactly like that in most browsers, is actually interpreted by the browser and by JavaScript ashttp://example.com/%D1%81%D1%82%D0%B0%D1%82%D0%B8%D1%81%D1%82%D0%B8%D0%BA%D0%B0, so that's what Ziggy sees too.The fix in this PR does work, but I'm still a bit uneasy about it because I'm not sure what else it might affect unintentionally. Might add more tests or sit on it for a bit.
Fixes #665.