Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

css cleanup, list-reset removed from Tailwind 1.x #48

Merged
merged 1 commit into from Aug 15, 2019

Conversation

cameronelliott
Copy link

This is super duper minor PR, but will clean up a little cruft from the code anyway.
Tailwind 1.x removed list-reset from it's definitions, so specifying this class was a NOP.

@cameronelliott
Copy link
Author

I think this is okay, after having a moment of doubt.

Here is the guidance for removing the list-reset util classes:
tailwind upgrade link

After re-reading it, and reviewing source_assets\sass_base.scss, I think this is good after all,
there is some styling of ul/li/ol in _base.scss, but it's just margins (.my-*) so I think it's okay.

@mattstauffer mattstauffer merged commit b5fbf37 into tighten:master Aug 15, 2019
@mattstauffer
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants