Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring and adding fail safe on disconnect #9

Open
S-S-X opened this issue Feb 13, 2020 · 1 comment
Open

Refactoring and adding fail safe on disconnect #9

S-S-X opened this issue Feb 13, 2020 · 1 comment

Comments

@S-S-X
Copy link

S-S-X commented Feb 13, 2020

Original issue

pandorabox-io/pandorabox.io#233

If player disconnects and reconnects while riding elevator he will be detached from elevator, fall down the shaft, possibly die and no bones will be placed (items and bones drop to ground).

What is already done?

Started refactoring elevator code by adding namespace and nearly 1000 loc init.lua into separate files:
https://github.com/S-S-X/elevator/projects/1

Current progress in refactor branch:
https://github.com/S-S-X/elevator/tree/refactor

Refactor should not contain significant modifications to original code.

What will be done?

Refactoring code to provide usable API, it might or might not be useful for other mods but will be useful for keeping internal stuff in good shape.

Any updates on this?

Check mentioned project / subscribe for notification if you want to get more updates on this.

shacknetisp pushed a commit that referenced this issue Jun 16, 2021
@shacknetisp
Copy link
Member

The original issue (falling to death) has been addressed by making shafts climbable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants