fix: set createdAt timestamp field value on collection insert if not exists #303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adilansari
reviewed
Apr 14, 2023
| const collectionCreatedAtFieldNames = collectionFields.filter((field) => { | ||
| return field?.schemaFieldOptions?.timestamp === "createdAt"; | ||
| }).map(f => f.name); | ||
|
|
There was a problem hiding this comment.
Thanks for addressing the issue @akhill10 . We can cache the collectionCreatedAtFieldNames at instantiation in constructor. That will significantly improve the performance. We will be good to merge this then.
There was a problem hiding this comment.
Good suggestion. We can tackle that in a separate PR.
ovaistariq
approved these changes
Apr 14, 2023
|
@akhill10 thank you for your contribution |
|
🎉 This PR is included in version 1.0.0-beta.45 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
/claim #245
How best to test these changes
Issue ticket number and link
Fixes #245