New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Facet stats support for numeric fields #409
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
b38fa94
feat: Facet stats support for numeric fields
adilansari 86a3923
chore: Updating gh action env ubuntu to 22.04
adilansari 47b04bf
test: Fix marshaler test to consume pointer
adilansari 1a9dfaa
chore: Installing proto compiler from gh releases
adilansari File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
Submodule proto
updated
from 0588fc to 21374e
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -22,6 +22,8 @@ RUN apt-get update && \ | |
curl \ | ||
gcc \ | ||
git \ | ||
unzip \ | ||
libc6-dev \ | ||
make \ | ||
sudo | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -21,6 +21,8 @@ RUN apt-get update && \ | |
curl \ | ||
wget \ | ||
gcc \ | ||
libc6-dev \ | ||
unzip \ | ||
git \ | ||
make \ | ||
sudo | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -16,6 +16,8 @@ set -ex | |
|
||
# Settings | ||
FDB_VERSION=7.1.7 | ||
PROTO_VERSION=3.15.8 | ||
PROTO_RELEASES="https://github.com/protocolbuffers/protobuf/releases" | ||
|
||
### Prereqs checks ### | ||
# Check if architecture and OS is supported | ||
|
@@ -24,74 +26,98 @@ ARCH=$(uname -m) | |
OS=$(uname -s) | ||
|
||
case "${OS}-${ARCH}" in | ||
"Darwin-arm64") | ||
BINARIES="brew curl go" | ||
FDB_SHA=b456a1d03580f81394502e1b066006ec38bf6a3a17a9904e6d7a88badbea4b4a08b9dbf69fbb0057b46dd5043f23de9ec3ff7a77d767c23f872425eb73fdee18 | ||
;; | ||
"Darwin-x86_64") | ||
BINARIES="brew curl go" | ||
FDB_SHA=0e9d147410eede58d121fdc9208ea7b04a7c74c8f3776f56cfc00233cfb3a358a0e2f992122718ef9c639928b081801da542e9c4b07a539c8fd73361ab43beec | ||
;; | ||
"Linux-aarch64") | ||
BINARIES="apt-get curl go" | ||
FDB_SHA=c994ebb01a660cff9ef699a0e38482a561679db04c02c256efae25ba687cf903 | ||
;; | ||
"Linux-arm64") | ||
BINARIES="apt-get curl go" | ||
FDB_SHA=c994ebb01a660cff9ef699a0e38482a561679db04c02c256efae25ba687cf903 | ||
;; | ||
"Linux-x86_64") | ||
BINARIES="apt-get curl go" | ||
FDB_SHA=471f6bf4a7af40abc69027aa0d4f452ee83715a43a555008303ca255f6bd6db1 | ||
;; | ||
*) | ||
echo "Unsupported architecture ${ARCH} or operating system ${OS}." | ||
exit 1 | ||
"Darwin-arm64") | ||
BINARIES="brew curl go" | ||
FDB_SHA=b456a1d03580f81394502e1b066006ec38bf6a3a17a9904e6d7a88badbea4b4a08b9dbf69fbb0057b46dd5043f23de9ec3ff7a77d767c23f872425eb73fdee18 | ||
;; | ||
"Darwin-x86_64") | ||
BINARIES="brew curl go" | ||
FDB_SHA=0e9d147410eede58d121fdc9208ea7b04a7c74c8f3776f56cfc00233cfb3a358a0e2f992122718ef9c639928b081801da542e9c4b07a539c8fd73361ab43beec | ||
;; | ||
"Linux-aarch64") | ||
BINARIES="apt-get curl go" | ||
FDB_SHA=c994ebb01a660cff9ef699a0e38482a561679db04c02c256efae25ba687cf903 | ||
;; | ||
"Linux-arm64") | ||
BINARIES="apt-get curl go" | ||
FDB_SHA=c994ebb01a660cff9ef699a0e38482a561679db04c02c256efae25ba687cf903 | ||
;; | ||
"Linux-x86_64") | ||
BINARIES="apt-get curl go" | ||
FDB_SHA=471f6bf4a7af40abc69027aa0d4f452ee83715a43a555008303ca255f6bd6db1 | ||
;; | ||
*) | ||
echo "Unsupported architecture ${ARCH} or operating system ${OS}." | ||
exit 1 | ||
;; | ||
esac | ||
|
||
# Check if required binaries are available in PATH | ||
for bin in ${BINARIES}; do | ||
binpath=$(command -v "${bin}") | ||
if [ -z "${binpath}" ] || ! test -x "${binpath}"; then | ||
echo "Please ensure that $bin binary is installed and in PATH." | ||
exit 1 | ||
fi | ||
binpath=$(command -v "${bin}") | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. whitespace only |
||
if [ -z "${binpath}" ] || ! test -x "${binpath}"; then | ||
echo "Please ensure that $bin binary is installed and in PATH." | ||
exit 1 | ||
fi | ||
done | ||
|
||
# Install protobuf compiler via package manager | ||
# Install protobuf compiler | ||
case "${OS}" in | ||
"Darwin") | ||
brew install protobuf | ||
;; | ||
"Linux") | ||
sudo apt-get update | ||
sudo apt-get install -y protobuf-compiler | ||
;; | ||
"Darwin") | ||
brew install protobuf | ||
;; | ||
"Linux") | ||
case "${ARCH}" in | ||
"x86_64") | ||
PROTO_PKG=protoc-$PROTO_VERSION-linux-x86_64.zip | ||
;; | ||
"aarch64") | ||
PROTO_PKG=protoc-$PROTO_VERSION-linux-aarch_64.zip | ||
;; | ||
*) | ||
echo "No supported proto compiler for ${ARCH} or operating system ${OS}." | ||
exit 1 | ||
;; | ||
esac | ||
;; | ||
*) | ||
echo "No supported proto compiler for ${ARCH} or operating system ${OS}." | ||
exit 1 | ||
;; | ||
esac | ||
|
||
if [ -n "$PROTO_PKG" ]; then | ||
DOWNLOAD_URL=$PROTO_RELEASES/download/v$PROTO_VERSION/$PROTO_PKG | ||
echo "Fetching protobuf release ${DOWNLOAD_URL}" | ||
curl -LO $DOWNLOAD_URL | ||
sudo unzip $PROTO_PKG -d "/usr/local/" | ||
sudo chmod +x "/usr/local/bin/protoc" | ||
sudo chmod -R 755 "/usr/local/include/" | ||
fi | ||
|
||
# Install protobuf | ||
export GO111MODULE=on | ||
go install google.golang.org/protobuf/cmd/protoc-gen-go@v1 | ||
go install google.golang.org/grpc/cmd/protoc-gen-go-grpc@v1 | ||
go install github.com/grpc-ecosystem/grpc-gateway/v2/protoc-gen-grpc-gateway@v2 | ||
go install github.com/google/gnostic/cmd/protoc-gen-openapi@v0 #generate openapi 3.0 spec | ||
go install github.com/deepmap/oapi-codegen/cmd/oapi-codegen@v1 #generate go http client | ||
go install github.com/mikefarah/yq/v4@latest # used to fix OpenAPI spec in scripts/fix_openapi.sh | ||
go install github.com/mikefarah/yq/v4@latest # used to fix OpenAPI spec in scripts/fix_openapi.sh | ||
|
||
# Install FoundationDB package | ||
case "${OS}" in | ||
"Darwin") | ||
FDB_PACKAGE_NAME="FoundationDB-${FDB_VERSION}_${ARCH}.pkg" | ||
FDB_PACKAGE_PATH="$(mktemp -d)/${FDB_PACKAGE_NAME}" | ||
curl --create-dirs -Lo "$FDB_PACKAGE_PATH" "https://tigrisdata-pub.s3.us-west-2.amazonaws.com/${FDB_PACKAGE_NAME}" | ||
echo "$FDB_SHA $FDB_PACKAGE_PATH" | shasum -a 512 -c | ||
sudo installer -pkg "$FDB_PACKAGE_PATH" -target / | ||
;; | ||
"Linux") | ||
FDB_PACKAGE_NAME="foundationdb-clients_${FDB_VERSION}-1_${ARCH}.deb" | ||
FDB_PACKAGE_PATH="$(mktemp -p /tmp/ -u)/${FDB_PACKAGE_NAME}" | ||
curl --create-dirs -Lo "$FDB_PACKAGE_PATH" "https://tigrisdata-pub.s3.us-west-2.amazonaws.com/ubuntu/focal/${FDB_PACKAGE_NAME}" | ||
echo "$FDB_SHA $FDB_PACKAGE_PATH" | sha256sum -c | ||
sudo dpkg -i "$FDB_PACKAGE_PATH" # provides /lib/libfdb_c.so shared library in the docker for CGO | ||
;; | ||
"Darwin") | ||
FDB_PACKAGE_NAME="FoundationDB-${FDB_VERSION}_${ARCH}.pkg" | ||
FDB_PACKAGE_PATH="$(mktemp -d)/${FDB_PACKAGE_NAME}" | ||
curl --create-dirs -Lo "$FDB_PACKAGE_PATH" "https://tigrisdata-pub.s3.us-west-2.amazonaws.com/${FDB_PACKAGE_NAME}" | ||
echo "$FDB_SHA $FDB_PACKAGE_PATH" | shasum -a 512 -c | ||
sudo installer -pkg "$FDB_PACKAGE_PATH" -target / | ||
;; | ||
"Linux") | ||
FDB_PACKAGE_NAME="foundationdb-clients_${FDB_VERSION}-1_${ARCH}.deb" | ||
FDB_PACKAGE_PATH="$(mktemp -p /tmp/ -u)/${FDB_PACKAGE_NAME}" | ||
curl --create-dirs -Lo "$FDB_PACKAGE_PATH" "https://tigrisdata-pub.s3.us-west-2.amazonaws.com/ubuntu/focal/${FDB_PACKAGE_NAME}" | ||
echo "$FDB_SHA $FDB_PACKAGE_PATH" | sha256sum -c | ||
sudo dpkg -i "$FDB_PACKAGE_PATH" # provides /lib/libfdb_c.so shared library in the docker for CGO | ||
;; | ||
esac |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -22,6 +22,8 @@ RUN apt-get update && \ | |
gcc \ | ||
git \ | ||
golang \ | ||
unzip \ | ||
libc6-dev \ | ||
make \ | ||
sudo | ||
|
||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
whitespace tidy