fix: Handle missing decorator for model #364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you @tachyonicbytes for this first contribution! |
|
Reviewpad Report
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #364 +/- ##
==========================================
+ Coverage 90.24% 90.26% +0.02%
==========================================
Files 29 29
Lines 5595 5608 +13
Branches 657 661 +4
==========================================
+ Hits 5049 5062 +13
Misses 545 545
Partials 1 1
☔ View full report in Codecov by Sentry. |
adilansari
previously approved these changes
May 11, 2023
adilansari
dismissed
their stale review
Can you please fix the PR title. (Suffixing it with "fix:" should be enough)
|
Sure |
tachyonicbytes
changed the title
tachyonicbytes
changed the title
adilansari
approved these changes
May 11, 2023
|
🎉 This PR is included in version 1.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
Solves #343. Return a more descriptive error message when the
@TigrisSearchIndexdecorator is not set.Related Tickets & Documents
Related Issue Improve error messaging when a createOrUpdateIndex is called but the TigrisSearchIndex for the index hasn't been set #343
Closes Improve error messaging when a createOrUpdateIndex is called but the TigrisSearchIndex for the index hasn't been set #343
Added/updated tests?
have not been included
Is this change backwards compatible?
Does it require updates to Tigris docs?
and replace this text as
tigrisdata/tigris-docs#123Checklist
npm run build- builds successfullynpm run test- tests passingnpm run lint- no lint errors[optional] Are there any post deployment tasks we need to perform?
/claim #343