Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Facet stats support for numeric fields #409

Merged
merged 4 commits into from Aug 10, 2022
Merged

feat: Facet stats support for numeric fields #409

merged 4 commits into from Aug 10, 2022

Conversation

adilansari
Copy link
Contributor

@adilansari adilansari commented Aug 9, 2022 •
edited

  • Upgraded ts search client to 0.6.0
  • Updated api to have optional facet stats fields
  • Updated proto compiler to 3.15, this required changes in build dockerfiles only

Response when faceting string fields

"facets": {
            "brand": {
                "counts": [
                    {
                        "count": 5,
                        "value": "Nike"
                    }
                ],
                "stats": {
                    "count": 2
                }
            },
}

Response when faceting numeric fields

        "facets": {
            "review.votes.upvotes": {
                "counts": [ .... ],
                "stats": {
                    "avg": 15.102804183959961,
                    "max": 30,
                    "min": 0,
                    "sum": 1616,
                    "count": 31
                }
            }
        },

@adilansari adilansari force-pushed the search-client-upgrade branch 2 times, most recently from 708c63e to aac1504 Compare August 9, 2022 23:04
@codecov-commenter
Copy link

codecov-commenter commented Aug 10, 2022 •
edited

Codecov Report

Merging #409 (720f91b) into main (8046e7e) will decrease coverage by 0.04%.
The diff coverage is 42.85%.

@@            Coverage Diff             @@
##             main     #409      +/-   ##
==========================================
- Coverage   28.55%   28.51%   -0.05%     
==========================================
  Files          72       72              
  Lines        7725     7726       +1     
==========================================
- Hits         2206     2203       -3     
- Misses       5280     5284       +4     
  Partials      239      239
Impacted Files Coverage Δ
server/services/v1/search_reader.go 0.00% <0.00%> (ø)
api/server/v1/marshaler.go 18.22% <100.00%> (ø)
server/services/v1/query_runner.go 6.34% <100.00%> (-0.39%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

adilansari
adilansari commented Aug 10, 2022
View reviewed changes
scripts/install_build_deps.sh
*)
echo "Unsupported architecture ${ARCH} or operating system ${OS}."
exit 1
"Darwin-arm64")
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whitespace tidy

adilansari
adilansari commented Aug 10, 2022
View reviewed changes
scripts/install_build_deps.sh
echo "Please ensure that $bin binary is installed and in PATH."
exit 1
fi
binpath=$(command -v "${bin}")
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whitespace only

@adilansari adilansari merged commit e782bb6 into main Aug 10, 2022
@adilansari adilansari deleted the search-client-upgrade branch August 10, 2022 19:27
adilansari added a commit that referenced this pull request Aug 10, 2022
@adilansari @himank
@mattayres @JigarJoshi @efirs @pboros
Release (#411)
9411d91 
* refac: refactor transaction handling to optimize writes

* feat: added minimal pubsub implementation

* feat: updated minimal pubsub implementation per feedback

* feat: Added support for oauth

* chore: Fix GetInfo test. Fix unneeded quota manager assignment

* refactor: Improve integrations tests

* Allow to run/debug individual tests in IDE
* Fix local_run target. Now FDB on the host should not be needed.
* Fix exit code of `make test`

* fix: Fix search response marshalling

* chore: Added auth failure logs

* feat: db and collection name tags in traces (#402)

* feat: Facet stats support for numeric fields (#409)

* feat: Facet stats support for numeric fields

* chore: Updating gh action env ubuntu to 22.04

* test: Fix marshaler test to consume pointer

* chore: Installing proto compiler from gh releases

Co-authored-by: Himank Chaudhary <himank@tigrisdata.com>
Co-authored-by: Matt Ayres <matt.ayres@gmail.com>
Co-authored-by: Jigar Joshi <jigarjm@gmail.com>
Co-authored-by: Yevgeniy Firsov <firsov@tigrisdata.com>
Co-authored-by: Peter Boros <pboros@tigrisdata.com>
@tigrisdata-argocd-bot
Copy link
Collaborator

🎉 This PR is included in version 1.0.0-alpha.27 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@tigrisdata-argocd-bot
Copy link
Collaborator

🎉 This PR is included in version 1.0.0-beta.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@himank himank himank approved these changes

Assignees
No one assigned
Labels
released on @alpha released on @beta
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@adilansari @codecov-commenter @tigrisdata-argocd-bot @himank