Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Papiamento translations for devise #239

Merged
merged 3 commits into from Sep 23, 2018
Merged

Conversation

acesuares
Copy link

Papiamento is the language of the ABC-islands: Aruba, Bonaire, and Curaçao.

It's ISO 639-2 code is pap, but there are two ortographies.

pap-AW is the orhography of Aruba, and pap-CW is the one for Bonaire and Curaçao.
(In fact, pap-BQ is for Bonaire and pap-CW for Curaçao, but at this moment those two are the same and we do not us pap-BQ yet, this could change in the future).

Please add them if you would. After you add them, will they be available at 'Locale'?

Note: at this moment the two files are identical, we will start editing the pap-AW soon, but the changes are small (c=k, and such) so this pap-AW file will be a good starting point.

Thank you.

@JasonBarnabe
Copy link
Collaborator

I would be glad to include this.

The tests are failing I believe because https://github.com/tigrish/iso does not contain any information on the language. I see that you previously created Locale/iso#3 but it does not appear sufficient things were added.

2.4.0 :001 > require 'iso'
 => true 
2.4.0 :002 > ISO::Language.find('pap')
 => nil 

@acesuares
Copy link
Author

Hmm... it seems to me that the iso folder only handles iso-639 and not iso-639-2. pap is in the language list of iso 639-2 but not in the two-letter-only list of iso-639.

I ran into the same problem with rails-i18n, it seems only 2 letter codes for languages are recognized...

@acesuares
Copy link
Author

Quite shocking that none of the three letter languages are implemented! How can we change that...! How can we help?

@JasonBarnabe
Copy link
Collaborator

This project uses https://github.com/tigrish/i18n-spec to check the correctness of locales. This in turn uses https://github.com/tigrish/iso to determine the plural forms required. https://github.com/tigrish/iso contains only ISO 639-1 alpha-2 (two letter) codes, which do not include Papiamento.

I will need to research the best way to resolve this. Possibilities include:

  • Augment i18n-spec with additional language lists which include Papiamento.
  • Switch i18n-spec to use an alternate source of pluralization data, such as https://github.com/svenfuchs/i18n
  • Modify i18n-spec to not check for pluralization if rules are not defined.
  • Skip this test in this repo for these languages.

Despite this project being in the same namespace, I do not have any special knowledge or rights in the iso or i18n-spec repos.

@acesuares
Copy link
Author

Thanx Jason! I am trying to work with tigrish/iso too, and there are more things that need to be fixed.
I submitted a pull request that also adds BQ and a locale for pap (language names etc). So the best thing would be to wait that out.

@acesuares
Copy link
Author

There seems to be no progress...

@acesuares
Copy link
Author

What to do to move this into the repo?

@JasonBarnabe
Copy link
Collaborator

I will set the tests to ignore these files. We already do this for zh-YUE.

@JasonBarnabe JasonBarnabe merged commit 1eb48f2 into tigrish:master Sep 23, 2018
@acesuares
Copy link
Author

Great & Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants