Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes for devise 4.9.0 #333

Merged
merged 3 commits into from Feb 19, 2023
Merged

Changes for devise 4.9.0 #333

merged 3 commits into from Feb 19, 2023

Conversation

JasonBarnabe
Copy link
Collaborator

@JasonBarnabe JasonBarnabe commented Feb 15, 2023

Closes #330.

Additionally:

  • Modify tests so they check devise's _error_messages.html.erb
  • Adjust how the resource name is looked up in registrations/edit.html.erb to match devise's lookup

- heartcombo/devise@f08e0ad
- heartcombo/devise@88625d4
- heartcombo/devise@49ed129

Additionally:

- Modify tests so they check devise's _error_messages.html.erb
- Adjust how the resource name is looked up in registrations/edit.html.erb to match devise's lookup
@JasonBarnabe
Copy link
Collaborator Author

This PR currently points to git to load devise 4.9.0. Will wait for their release to merge.

Copy link
Contributor

@JunichiIto JunichiIto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR. I added some comments.

Gemfile Outdated Show resolved Hide resolved
JasonBarnabe and others added 2 commits February 18, 2023 18:18
@JasonBarnabe JasonBarnabe merged commit ad00d15 into master Feb 19, 2023
@JasonBarnabe JasonBarnabe deleted the devise-4.9.0 branch February 19, 2023 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prepare for Devise 4.9.0
2 participants