Add aarch64 checks and auth to workflow #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joonas Rautiola <joonas.rautiola@unikie.com>
Signed-off-by: Joonas Rautiola <joonas.rautiola@unikie.com>
Signed-off-by: Joonas Rautiola <joonas.rautiola@unikie.com>
joinemm
force-pushed
the
pr-arm-checks
branch
2 times, most recently
from
44e2861
to
6fa602d
Compare
Signed-off-by: Joonas Rautiola <joonas.rautiola@unikie.com>
joinemm
changed the title
joinemm
changed the title
henrirosten
reviewed
Jun 17, 2024
henrirosten
reviewed
Jun 17, 2024
Signed-off-by: Joonas Rautiola <joonas.rautiola@unikie.com>
henrirosten
approved these changes
Jun 17, 2024
There was a problem hiding this comment.
In general, this seems fine but I don't have means to test this right now.
I assume @joinemm that you have been fully testing this in your fork. If that's the case, I'm fine with merging this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pull_request_target. The auth steps are similar what is being used in ghaf repo but simplified. Reasoning explained here https://ssrc.atlassian.net/wiki/x/OABjMgFYI the checks for this PR will fail as it's not able to use the secrets yet.
Tests done in my fork using alt account to make different PRs https://github.com/joinemm/ghaf-infra/pulls