-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Passthrough Jetson Orin WiFi card and Intel NUC Wifi Card to NetVM #107
Conversation
I rebased the commit from #93 and made some fixes so that now this actually builds. Also refactored NVIDIA specific passthroughs to the target-module so it doesn't mess up Intel NUC build. |
I'm still going to add commits which modularize stuff a bit, and add toggles to enable and disable stuff. And convert the device tree to an overlay |
#93 flashed for me and the netvm connected to my configured WIFI so that indicates it built on my machine but failed for you.
+1 |
27cfdbb
to
69f34da
Compare
It actually did work but it was based on much older branch and needed some changes after rebase, and even rebase had conflicts |
Rebasing and fixes, and refactoring of Orin specific NetVM attributes to the target module, added by Mika Tammi. Signed-off-by: Panu Finnila <panu.finnila@unikie.com> Co-authored-by: Mika Tammi <mika.tammi@unikie.com>
Update microvm.nix to a version which properly supports PCI passthrough on x86_64-linux Signed-off-by: Mika Tammi <mika.tammi@unikie.com>
Signed-off-by: Mika Tammi <mika.tammi@unikie.com>
fb1f70c
to
04bd011
Compare
Signed-off-by: Mika Tammi <mika.tammi@unikie.com>
ec526ff
to
3aea028
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
VM specific development modules I’d rather break to VM specific based on categories eventually. It would reduce VM/host size in development mode (think tools useful in GUIVM).
networking.wireless = { | ||
enable = true; | ||
|
||
# networks."SSID_OF_NETWORK".psk = "WPA_PASSWORD"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SSID / password we could also refactor like authentication.nix - would also support .gitignore for developer local secrets until we develop proper way to support these.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@mikatammi I’m not expecting you to fix the issues I created. Those would be good issues for someone new to project/nix. |
Rebasing and fixes, and refactoring of Orin specific NetVM attributes to the target module, added by Mika Tammi.