Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Passthrough Jetson Orin WiFi card and Intel NUC Wifi Card to NetVM #107

Merged
merged 4 commits into from
Apr 17, 2023

Conversation

mikatammi
Copy link
Contributor

Rebasing and fixes, and refactoring of Orin specific NetVM attributes to the target module, added by Mika Tammi.

@mikatammi mikatammi marked this pull request as draft April 12, 2023 19:37
@mikatammi
Copy link
Contributor Author

I rebased the commit from #93 and made some fixes so that now this actually builds. Also refactored NVIDIA specific passthroughs to the target-module so it doesn't mess up Intel NUC build.

@mikatammi
Copy link
Contributor Author

I'm still going to add commits which modularize stuff a bit, and add toggles to enable and disable stuff. And convert the device tree to an overlay

@vilvo
Copy link
Contributor

vilvo commented Apr 13, 2023

I rebased the commit from #93 and made some fixes so that now this actually builds.

#93 flashed for me and the netvm connected to my configured WIFI so that indicates it built on my machine but failed for you.

Also refactored NVIDIA specific passthroughs to the target-module so it doesn't mess up Intel NUC build.

+1

@mikatammi
Copy link
Contributor Author

I rebased the commit from #93 and made some fixes so that now this actually builds.

#93 flashed for me and the netvm connected to my configured WIFI so that indicates it built on my machine but failed for you.

Also refactored NVIDIA specific passthroughs to the target-module so it doesn't mess up Intel NUC build.

+1

It actually did work but it was based on much older branch and needed some changes after rebase, and even rebase had conflicts

panufi and others added 3 commits April 15, 2023 01:11
Rebasing and fixes, and refactoring of Orin specific NetVM attributes to
the target module, added by Mika Tammi.

Signed-off-by: Panu Finnila <panu.finnila@unikie.com>
Co-authored-by: Mika Tammi <mika.tammi@unikie.com>
Update microvm.nix to a version which properly supports PCI passthrough
on x86_64-linux

Signed-off-by: Mika Tammi <mika.tammi@unikie.com>
Signed-off-by: Mika Tammi <mika.tammi@unikie.com>
@mikatammi mikatammi changed the title Passthrough Jetson Orin WiFi card to NetVM Passthrough Jetson Orin WiFi card and Intel NUC Wifi Card to NetVM Apr 15, 2023
Signed-off-by: Mika Tammi <mika.tammi@unikie.com>
@mikatammi mikatammi marked this pull request as ready for review April 15, 2023 17:19
@mikatammi mikatammi requested a review from vadika April 15, 2023 17:21
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

VM specific development modules I’d rather break to VM specific based on categories eventually. It would reduce VM/host size in development mode (think tools useful in GUIVM).

networking.wireless = {
enable = true;

# networks."SSID_OF_NETWORK".psk = "WPA_PASSWORD";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SSID / password we could also refactor like authentication.nix - would also support .gitignore for developer local secrets until we develop proper way to support these.

Copy link
Contributor

@vilvo vilvo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vilvo
Copy link
Contributor

vilvo commented Apr 16, 2023

@mikatammi I’m not expecting you to fix the issues I created. Those would be good issues for someone new to project/nix.

@brianmcgillion brianmcgillion merged commit 6eb8a6e into main Apr 17, 2023
2 checks passed
@vilvo vilvo deleted the orin_netvm_wip branch April 17, 2023 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants