refactor set option to detect race risk

Signed-off-by: you06 <you1474600@gmail.com> commit intest package Signed-off-by: you06 <you1474600@gmail.com> update Signed-off-by: you06 <you1474600@gmail.com>
tikv · Mar 19, 2024 · ce69786 · ce69786
1 parent 44b2944
commit ce69786
Show file tree

Hide file tree

Showing 4 changed files with 265 additions and 80 deletions.
diff --git a/txnkv/transaction/2pc.go b/txnkv/transaction/2pc.go
@@ -468,16 +468,14 @@ func (c *PlainMutations) AppendMutation(mutation PlainMutation) {
 // newTwoPhaseCommitter creates a twoPhaseCommitter.
 func newTwoPhaseCommitter(txn *KVTxn, sessionID uint64) (*twoPhaseCommitter, error) {
 	committer := &twoPhaseCommitter{
-		store:             txn.store,
-		txn:               txn,
-		startTS:           txn.StartTS(),
-		sessionID:         sessionID,
-		regionTxnSize:     map[uint64]int{},
-		isPessimistic:     txn.IsPessimistic(),
-		binlog:            txn.binlog,
-		diskFullOpt:       kvrpcpb.DiskFullOpt_NotAllowedOnFull,
-		resourceGroupName: txn.resourceGroupName,
-	}
+		store:         txn.store,
+		txn:           txn,
+		startTS:       txn.StartTS(),
+		sessionID:     sessionID,
+		regionTxnSize: map[uint64]int{},
+		isPessimistic: txn.IsPessimistic(),
+	}
+	txn.commitActionContext.applyToCommitter(committer)
 	return committer, nil
 }