Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

internal/locate: change some retriable error logs to debug level #1004

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
+2 −2
Open

internal/locate: change some retriable error logs to debug level #1004

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
69f1dc7
internal/locate: change some retryable error logs to debug level
jackysp Oct 11, 2023
b1d36df
Merge branch 'master' into lower_down_log
disksing Nov 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions internal/locate/region_request.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2125,7 +2125,7 @@ func (s *RegionRequestSender) onRegionError(
if s.replicaSelector != nil {
return s.replicaSelector.onServerIsBusy(bo, ctx, req, serverIsBusy)
}
logutil.Logger(bo.GetCtx()).Warn(
logutil.Logger(bo.GetCtx()).Debug(
"tikv reports `ServerIsBusy` retry later",
zap.String("reason", regionErr.GetServerIsBusy().GetReason()),
zap.Stringer("ctx", ctx),
Expand Down Expand Up @@ -2232,7 +2232,7 @@ func (s *RegionRequestSender) onRegionError(
// This error is specific to stale read and the target replica is randomly selected. If the request is sent
// to the leader, the data must be ready, so we don't backoff here.
if regionErr.GetDataIsNotReady() != nil {
logutil.Logger(bo.GetCtx()).Warn(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We used to use this for diagnosis. A better but complex idea might be sampling logs.

logutil.Logger(bo.GetCtx()).Debug(
"tikv reports `DataIsNotReady` retry later",
zap.Uint64("store-id", ctx.Store.storeID),
zap.Uint64("peer-id", regionErr.GetDataIsNotReady().GetPeerId()),
Expand Down