tikvrpc: avoid data race on XxxRequest.Context
#1242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: zyguan <zhongyangguan@gmail.com>
Signed-off-by: zyguan <zhongyangguan@gmail.com>
cfzjywxk
reviewed
Mar 20, 2024
Signed-off-by: zyguan <zhongyangguan@gmail.com>
MyonKeminta
reviewed
Mar 21, 2024
| @@ -118,6 +118,11 @@ const ( | |||
| CmdEmpty CmdType = 3072 + iota | |||
| ) | |||
|
|
|||
| // CmdType aliases. | |||
| const ( | |||
| CmdGetKeyTTL = CmdRawGetKeyTTL | |||
| } else { | ||
| cmd := *req.${cmd}() | ||
| cmd.Context = ctx | ||
| req.Req = &cmd |
There was a problem hiding this comment.
May there still be data race on the reading/writing the pointer req.Req?
There was a problem hiding this comment.
No, I only see the data race on the value refered by the pointer, AFAIK, there is no concurrent access to the pointer field itself.
Signed-off-by: zyguan <zhongyangguan@gmail.com>
MyonKeminta
approved these changes
Mar 21, 2024
Does this have anything to do with this PR? |
@zyguan PTAL |
Signed-off-by: zyguan <zhongyangguan@gmail.com>
zyguan
added a commit
to zyguan/client-go
that referenced
this pull request
May 22, 2024
* tikvrpc: avoid data race on `XxxRequest.Context` Signed-off-by: zyguan <zhongyangguan@gmail.com> * fix grammar of codegen comment Signed-off-by: zyguan <zhongyangguan@gmail.com> * address comments Signed-off-by: zyguan <zhongyangguan@gmail.com> * check diff of go generate Signed-off-by: zyguan <zhongyangguan@gmail.com> * fix a typo Signed-off-by: zyguan <zhongyangguan@gmail.com> --------- Signed-off-by: zyguan <zhongyangguan@gmail.com>
cfzjywxk
pushed a commit
that referenced
this pull request
May 28, 2024
* tikvrpc: avoid data race on `XxxRequest.Context` * fix grammar of codegen comment * address comments * check diff of go generate * fix a typo --------- Signed-off-by: zyguan <zhongyangguan@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Try to fix pingcap/tidb#51921 . To reduce the memory allocation overhead, only do COW when
req.rev > 0.