region_requst: add req info in flashback region error #852
Conversation
Signed-off-by: Jason Mo <mohangjie1995@gmail.com>
internal/locate/region_request.go
Outdated
| @@ -1752,6 +1752,9 @@ func (s *RegionRequestSender) onRegionError( | |||
| return true, nil | |||
| } | |||
| } | |||
| logutil.BgLogger().Error("Region is in flashback progress", | |||
| zap.Stringer("req", req), | |||
There was a problem hiding this comment.
I'm inclined to contain these info inside the returned error, also consider the req can be nil.
Also, req.String() return weird things that no meaningful information is inside it. Maybe we should format some key fields of it.
|
@Defined2014 I suggest to attach the addtional info like this: |
ok. I found that we already have debug log in for this part, maybe we could try open debug log firstly. And not sure return such internal information in Error Msg is good or not. It's useless for user. |
Debug mode print too many logs... |
Signed-off-by: Jason Mo <mohangjie1995@gmail.com>
add more log for flashback when it meets error, ref pingcap/tidb#43673