Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CheckStoreHealth does not work wtih TiFlash #749

Closed
shiyuhang0 opened this issue May 20, 2023 · 0 comments · Fixed by #748
Closed

CheckStoreHealth does not work wtih TiFlash #749

shiyuhang0 opened this issue May 20, 2023 · 0 comments · Fixed by #748
Labels
type/bug Something isn't working

Comments

@shiyuhang0
Copy link
Collaborator

Bug Report

1. Describe the bug

The checkStoreHealth method in StoreHealthyChecker will check the status of the store periodically.

However, the check for TiFlash always fails and returns false because TiFlash does not provide the grpc health checking service. See here for more details about GRPC Health Checking Protocol

Thus, the status of TiFlash will always be unreachable.

2. Minimal reproduce step (Required)

3. What did you see instead (Required)

4. What did you expect to see? (Required)

5. What are your Java Client and TiKV versions? (Required)

  • Client Java: <= 3..3.4
  • TiKV: any version
@shiyuhang0 shiyuhang0 added the type/bug Something isn't working label May 20, 2023
zhangyangyu pushed a commit that referenced this issue May 25, 2023
Signed-off-by: shiyuhang <1136742008@qq.com>
shiyuhang0 added a commit to shiyuhang0/client-java that referenced this issue May 25, 2023
Signed-off-by: shiyuhang <1136742008@qq.com>
shiyuhang0 added a commit that referenced this issue May 31, 2023
* optimize getregionstore logical

Signed-off-by: shiyuhang <1136742008@qq.com>

* decrease impact

Signed-off-by: shiyuhang <1136742008@qq.com>

* Update RegionManager.java

Signed-off-by: shiyuhang <1136742008@qq.com>

* [close #749] Fix health checking issue (#748)

Signed-off-by: shiyuhang <1136742008@qq.com>

* Update RegionManager.java

Signed-off-by: shiyuhang <1136742008@qq.com>

* add log

Signed-off-by: shiyuhang <1136742008@qq.com>

* change log level

Signed-off-by: shiyuhang <1136742008@qq.com>

---------

Signed-off-by: shiyuhang <1136742008@qq.com>
ti-chi-bot pushed a commit to ti-chi-bot/client-java that referenced this issue May 31, 2023
Signed-off-by: shiyuhang <1136742008@qq.com>
shiyuhang0 added a commit that referenced this issue May 31, 2023
Signed-off-by: shiyuhang <1136742008@qq.com>
Co-authored-by: shi yuhang <52435083+shiyuhang0@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant