Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor follower read #126

Merged
merged 3 commits into from
Mar 26, 2021
Merged

refactor follower read #126

merged 3 commits into from
Mar 26, 2021

Conversation

marsishandsome
Copy link
Collaborator

@marsishandsome marsishandsome commented Feb 19, 2021 •
edited

Signed-off-by: marsishandsome marsishandsome@gmail.com

add configuration tikv.replica_read

  • LEADER
  • FOLLOWER
  • LEADER_AND_FOLLOWER

@marsishandsome marsishandsome changed the title refactor follower read [WIP] refactor follower read Feb 19, 2021
@marsishandsome marsishandsome force-pushed the feature/refactor-follower-read branch 6 times, most recently from 22a47c5 to 6bb9fd5 Compare March 25, 2021 06:48
@marsishandsome
Copy link
Collaborator Author

/run-all-tests

@marsishandsome marsishandsome force-pushed the feature/refactor-follower-read branch 2 times, most recently from 12390f7 to 8f93c1e Compare March 25, 2021 06:54
@marsishandsome
Copy link
Collaborator Author

/run-all-tests

@marsishandsome
Copy link
Collaborator Author

/run-all-tests

@marsishandsome marsishandsome force-pushed the feature/refactor-follower-read branch 2 times, most recently from ce4ed0d to 514883e Compare March 25, 2021 07:16
@marsishandsome
Copy link
Collaborator Author

/run-all-tests

@marsishandsome marsishandsome force-pushed the feature/refactor-follower-read branch 3 times, most recently from f7c6ad5 to 5cb1f76 Compare March 25, 2021 07:36
@marsishandsome
Copy link
Collaborator Author

/run-all-tests

@marsishandsome marsishandsome force-pushed the feature/refactor-follower-read branch 2 times, most recently from a62715b to bbcb3d0 Compare March 26, 2021 02:20
@marsishandsome
refactor follower read api
0393126 
Signed-off-by: marsishandsome <marsishandsome@gmail.com>
@marsishandsome
Copy link
Collaborator Author

/run-all-tests

@marsishandsome
fix
bf0117b 
Signed-off-by: marsishandsome <marsishandsome@gmail.com>
@marsishandsome
Copy link
Collaborator Author

/run-all-tests

@marsishandsome marsishandsome changed the title [WIP] refactor follower read refactor follower read Mar 26, 2021
birdstorm
birdstorm approved these changes Mar 26, 2021
View reviewed changes
Copy link
Collaborator

@birdstorm birdstorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM

src/main/java/org/tikv/common/region/TiRegion.java Outdated Show resolved Hide resolved
src/test/java/org/tikv/integration/IntegrationTest.java Outdated Show resolved Hide resolved
@marsishandsome
address codereview
350d220 
Signed-off-by: marsishandsome <marsishandsome@gmail.com>
@marsishandsome
Copy link
Collaborator Author

/run-all-tests

birdstorm
birdstorm approved these changes Mar 26, 2021
View reviewed changes
Copy link
Collaborator

@birdstorm birdstorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marsishandsome marsishandsome merged commit e84f2f8 into tikv:master Mar 26, 2021
ti-srebot pushed a commit to ti-srebot/client-java that referenced this pull request Jun 23, 2021
@marsishandsome @ti-srebot
cherry pick tikv#126 to release-3.1
f6ea068 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jun 23, 2021
Merged
@ti-srebot
Copy link
Collaborator

cherry pick to release-3.1 in PR #209

birdstorm added a commit that referenced this pull request Jun 23, 2021
@ti-srebot @marsishandsome @birdstorm
refactor follower read (#126) (#209)
031745b 
* cherry pick #126 to release-3.1

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

* fix conflict

Signed-off-by: birdstorm <samuelwyf@hotmail.com>

Co-authored-by: Liangliang Gu <marsishandsome@gmail.com>
Co-authored-by: birdstorm <samuelwyf@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@birdstorm birdstorm birdstorm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@marsishandsome @ti-srebot @birdstorm