Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add request retry number metrics for client #183

Merged
merged 1 commit into from
Jun 4, 2021

Conversation

birdstorm
Copy link
Collaborator

Signed-off-by: birdstorm samuelwyf@hotmail.com

What problem does this PR solve?

Add a new metrics that records the number of gRPC request retries for each type.

Related changes

  • Need to cherry-pick to the release branch

Signed-off-by: birdstorm <samuelwyf@hotmail.com>
Copy link
Collaborator

@marsishandsome marsishandsome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@birdstorm
Copy link
Collaborator Author

/merge

@birdstorm birdstorm merged commit a3ac697 into tikv:master Jun 4, 2021
@birdstorm birdstorm deleted the add-retry-metrics branch June 4, 2021 07:41
ti-srebot pushed a commit to ti-srebot/client-java that referenced this pull request Jun 4, 2021
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Collaborator

cherry pick to release-3.1 in PR #184

marsishandsome pushed a commit that referenced this pull request Jun 7, 2021
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: birdstorm <samuelwyf@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants