Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

keep README update #197

Merged
merged 1 commit into from
Jun 16, 2021
Merged

keep README update #197

merged 1 commit into from
Jun 16, 2021

Conversation

marsishandsome
Copy link
Collaborator

@marsishandsome marsishandsome commented Jun 16, 2021 •
edited

What problem does this PR solve?

close #178

What is changed and how it works?

  • remote Chinese character
  • fix error in code example
  • update version in pom example

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation
  • Need to be included in the release note

@marsishandsome marsishandsome force-pushed the feature/update-document-example branch 2 times, most recently from 55e2e25 to 5b9be68 Compare June 16, 2021 06:08
@marsishandsome
update readme
e9fd48e 
Signed-off-by: marsishandsome <marsishandsome@gmail.com>
@marsishandsome marsishandsome force-pushed the feature/update-document-example branch from 5b9be68 to e9fd48e Compare June 16, 2021 06:09
@marsishandsome
Copy link
Collaborator Author

@birdstorm PTAL

birdstorm
birdstorm approved these changes Jun 16, 2021
View reviewed changes
Copy link
Collaborator

@birdstorm birdstorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marsishandsome marsishandsome merged commit 7fe64c6 into tikv:master Jun 16, 2021
ti-srebot pushed a commit to ti-srebot/client-java that referenced this pull request Jun 25, 2021
@marsishandsome @ti-srebot
cherry pick tikv#197 to release-3.1
927ca07 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jun 25, 2021
Merged
@ti-srebot
Copy link
Collaborator

cherry pick to release-3.1 in PR #217

birdstorm added a commit that referenced this pull request Jun 25, 2021
@ti-srebot @marsishandsome @birdstorm
keep README update (#197) (#217)
2aa5845 
* cherry pick #197 to release-3.1

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

* resolve conflicts

Signed-off-by: birdstorm <samuelwyf@hotmail.com>

Co-authored-by: Liangliang Gu <marsishandsome@gmail.com>
Co-authored-by: birdstorm <samuelwyf@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@birdstorm birdstorm birdstorm approved these changes

Assignees
No one assigned
Labels
status/LGT1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

keep README update
3 participants
@marsishandsome @ti-srebot @birdstorm