Support grpc forward #198
Merged
Support grpc forward #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Little-Wallace <bupt2013211450@gmail.com>
Signed-off-by: Little-Wallace <bupt2013211450@gmail.com>
Signed-off-by: Little-Wallace <bupt2013211450@gmail.com>
MyonKeminta
reviewed
Jun 16, 2021
| @@ -72,6 +75,7 @@ private static void loadFromDefaultProperties() { | |||
| setIfMissing(TIKV_METRICS_ENABLE, DEF_METRICS_ENABLE); | |||
| setIfMissing(TIKV_METRICS_PORT, DEF_METRICS_PORT); | |||
| setIfMissing(TIKV_NETWORK_MAPPING_NAME, DEF_TIKV_NETWORK_MAPPING_NAME); | |||
| setIfMissing(TIKV_ENABLE_GRPC_FORWARD, false); | |||
There was a problem hiding this comment.
Looks like you'd better define a DEF_ENABLE_GRPC_FORWARD
| if (checkHealth(store)) { | ||
| return true; | ||
| } else { | ||
| store.invalid(); |
There was a problem hiding this comment.
Does the function invalid actually means invalidate?
| @@ -32,6 +33,8 @@ | |||
|
|
|||
| private static final Logger logger = LoggerFactory.getLogger(TiConfiguration.class); | |||
| private static final ConcurrentHashMap<String, String> settings = new ConcurrentHashMap<>(); | |||
| public static final Metadata.Key FORWARD_META_DATA_KEY = | |||
There was a problem hiding this comment.
Suggested change
| public static final Metadata.Key FORWARD_META_DATA_KEY = | |
| public static final Metadata.Key FORWARD_METADATA_KEY = |
Signed-off-by: Little-Wallace <bupt2013211450@gmail.com>
Signed-off-by: Little-Wallace <bupt2013211450@gmail.com>
Signed-off-by: Little-Wallace <bupt2013211450@gmail.com>
MyonKeminta
reviewed
Jun 18, 2021
| @@ -76,6 +77,7 @@ | |||
| public static final boolean DEF_METRICS_ENABLE = false; | |||
| public static final int DEF_METRICS_PORT = 3140; | |||
| public static final String DEF_TIKV_NETWORK_MAPPING_NAME = ""; | |||
| public static final boolean DEF_GRPC_FORWARD_ENABLE = true; | |||
MyonKeminta
reviewed
Jun 18, 2021
Comment on lines
28
to
35
| TiStore oldStore = this.stores.get(Long.valueOf(store.getId())); | ||
| if (oldStore != null) { | ||
| return; | ||
| } | ||
| synchronized (this.taskQueue) { | ||
| this.stores.put(Long.valueOf(store.getId()), store); | ||
| this.taskQueue.add(store); | ||
| } |
There was a problem hiding this comment.
Is this function possible to be called concurrently? May it be a race that multiple threads do the check-and-insert-if-not-exist operation at the same time?
| continue; | ||
| } | ||
| } finally { | ||
| } |
There was a problem hiding this comment.
What's the purpose of the try-finally?
| List<TiStore> unhealthStore = getUnhealthStore(); | ||
| List<TiStore> restStore = new LinkedList<>(); | ||
| for (TiStore store : unhealthStore) { | ||
| String addressStr = store.getStore().getAddress(); |
There was a problem hiding this comment.
Did you check if the store becomes tombstone?
There was a problem hiding this comment.
No, the store will not be tombstone after it was created. Because it is a final object.
Signed-off-by: Little-Wallace <bupt2013211450@gmail.com>
MyonKeminta
approved these changes
Jun 18, 2021
ti-srebot
approved these changes
Jun 18, 2021
Signed-off-by: Little-Wallace <bupt2013211450@gmail.com>
Signed-off-by: Little-Wallace <bupt2013211450@gmail.com>
Signed-off-by: Little-Wallace <bupt2013211450@gmail.com>
ti-srebot
pushed a commit
to ti-srebot/client-java
that referenced
this pull request
Jun 23, 2021
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
cherry pick to release-3.1 in PR #208 |
birdstorm
pushed a commit
to ti-srebot/client-java
that referenced
this pull request
Jun 23, 2021
* support grpc forward for tikv client Signed-off-by: Little-Wallace <bupt2013211450@gmail.com>
birdstorm
pushed a commit
to ti-srebot/client-java
that referenced
this pull request
Jun 23, 2021
* support grpc forward for tikv client Signed-off-by: Little-Wallace <bupt2013211450@gmail.com> Signed-off-by: birdstorm <samuelwyf@hotmail.com>
birdstorm
added a commit
that referenced
this pull request
Jun 23, 2021
* Support grpc forward (#198) * support grpc forward for tikv client Signed-off-by: Little-Wallace <bupt2013211450@gmail.com> Signed-off-by: birdstorm <samuelwyf@hotmail.com> * fix compile Signed-off-by: birdstorm <samuelwyf@hotmail.com> Co-authored-by: Wallace <bupt2013211450@gmail.com> Co-authored-by: birdstorm <samuelwyf@hotmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
When TiKV cluster deploy in three IDC A/B/C, if there is network isolation between the A and B, the message which should be send to leader in A can be forward by B.
What is changed and how it works?
Check List
Tests
Code changes
Side effects
Related changes