Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix not stop scheduler #207

Merged
merged 2 commits into from
Jun 23, 2021
Merged

fix not stop scheduler #207

merged 2 commits into from
Jun 23, 2021

Conversation

Little-Wallace
Copy link
Contributor

@Little-Wallace Little-Wallace commented Jun 23, 2021 •
edited by marsishandsome

Signed-off-by: Little-Wallace bupt2013211450@gmail.com

What problem does this PR solve?

close #205

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation
  • Need to be included in the release note

@Little-Wallace
fix not stop scheduler
b94fbbe 
Signed-off-by: Little-Wallace <bupt2013211450@gmail.com>
birdstorm
birdstorm approved these changes Jun 23, 2021
View reviewed changes
Copy link
Collaborator

@birdstorm birdstorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Little-Wallace
address comment
89d8556 
Signed-off-by: Little-Wallace <bupt2013211450@gmail.com>
@Little-Wallace Little-Wallace merged commit 550487d into tikv:master Jun 23, 2021
ti-srebot pushed a commit to ti-srebot/client-java that referenced this pull request Jun 23, 2021
@Little-Wallace @ti-srebot
cherry pick tikv#207 to release-3.1
f1ae4b4 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jun 23, 2021
Merged
@ti-srebot
Copy link
Collaborator

cherry pick to release-3.1 in PR #210

birdstorm added a commit that referenced this pull request Jun 23, 2021
@ti-srebot @Little-Wallace @birdstorm
cherry pick #207 to release-3.1 (#210)
05f1559 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: Wallace <bupt2013211450@gmail.com>
Co-authored-by: birdstorm <samuelwyf@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marsishandsome marsishandsome marsishandsome left review comments

@birdstorm birdstorm birdstorm approved these changes

Assignees
No one assigned
Labels
status/LGT1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] JVM does not exit after this PR https://github.com/tikv/client-java/pull/198
4 participants
@Little-Wallace @ti-srebot @marsishandsome @birdstorm