Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix test #235

Merged
merged 7 commits into from
Jul 21, 2021
Merged

fix test #235

merged 7 commits into from
Jul 21, 2021

Conversation

Little-Wallace
Copy link
Contributor

Signed-off-by: Little-Wallace bupt2013211450@gmail.com

What problem does this PR solve?

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation
  • Need to be included in the release note

@Little-Wallace
fix test
28f7af2 
Signed-off-by: Little-Wallace <bupt2013211450@gmail.com>
@Little-Wallace
fix fmt
c9ff61a 
Signed-off-by: Little-Wallace <bupt2013211450@gmail.com>
birdstorm
birdstorm approved these changes Jul 20, 2021
View reviewed changes
Copy link
Collaborator

@birdstorm birdstorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@birdstorm
Copy link
Collaborator

/merge

@ti-srebot
Copy link
Collaborator

/run-all-tests

@ti-srebot
Copy link
Collaborator

@Little-Wallace merge failed.

@Little-Wallace
Copy link
Contributor Author

/run-all-tests

@Little-Wallace
update stub when find store invalid
6f870c5 
Signed-off-by: Little-Wallace <bupt2013211450@gmail.com>
@Little-Wallace
Copy link
Contributor Author

/merge

@ti-srebot
Copy link
Collaborator

/run-all-tests

@Little-Wallace
remove some args
0da6cef 
Signed-off-by: Little-Wallace <bupt2013211450@gmail.com>
@ti-srebot
Copy link
Collaborator

@Little-Wallace merge failed.

@Little-Wallace
add some test print
716d35a 
Signed-off-by: Little-Wallace <bupt2013211450@gmail.com>
@Little-Wallace
Copy link
Contributor Author

/merge

@ti-srebot
Copy link
Collaborator

/run-all-tests

@ti-srebot
Copy link
Collaborator

@Little-Wallace merge failed.

@Little-Wallace
Copy link
Contributor Author

/run-all-tests

@Little-Wallace
fix log
3d1e280 
Signed-off-by: Little-Wallace <bupt2013211450@gmail.com>
@Little-Wallace
fix test
41979e8 
Signed-off-by: Little-Wallace <bupt2013211450@gmail.com>
@Little-Wallace
Copy link
Contributor Author

/merge

@ti-srebot
Copy link
Collaborator

/run-all-tests

@ti-srebot ti-srebot merged commit faf0cb4 into tikv:master Jul 21, 2021
@Little-Wallace Little-Wallace mentioned this pull request Jul 22, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@birdstorm birdstorm birdstorm approved these changes

Assignees
No one assigned
Labels
status/can-merge status/LGT1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Little-Wallace @birdstorm @ti-srebot