Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TiSession support graceful close #238

Merged
merged 1 commit into from
Jul 28, 2021
Merged

TiSession support graceful close #238

merged 1 commit into from
Jul 28, 2021

Conversation

marsishandsome
Copy link
Collaborator

@marsishandsome marsishandsome commented Jul 23, 2021 •
edited

What problem does this PR solve?

TiSession support graceful close

What is changed and how it works?

Current TiSession.close call ExecutorService.shutdownNow directly.

Add a new function TiSession.closeAwaitTermination:

  1. call ExecutorService.shutdown
  2. check status using ExecutorService.isTerminated, if all terminated return
  3. if timeout, call ExecutorService.shutdown

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation
  • Need to be included in the release note

@marsishandsome
TiSession support graceful close
173eeda 
Signed-off-by: marsishandsome <marsishandsome@gmail.com>
@marsishandsome marsishandsome changed the title [WIP] TiSession support graceful close TiSession support graceful close Jul 23, 2021
@marsishandsome
Copy link
Collaborator Author

/run-all-tests

birdstorm
birdstorm approved these changes Jul 28, 2021
View reviewed changes
Copy link
Collaborator

@birdstorm birdstorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marsishandsome marsishandsome merged commit 257f306 into tikv:master Jul 28, 2021
ti-srebot pushed a commit to ti-srebot/client-java that referenced this pull request Jul 28, 2021
@marsishandsome @ti-srebot
cherry pick tikv#238 to release-3.1
4b187ee 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jul 28, 2021
Closed
@ti-srebot
Copy link
Collaborator

cherry pick to release-3.1 in PR #243

marsishandsome added a commit to marsishandsome/client-java that referenced this pull request Jul 28, 2021
@marsishandsome
TiSession support graceful close (tikv#238)
9368c99 
Signed-off-by: marsishandsome <marsishandsome@gmail.com>
@marsishandsome marsishandsome mentioned this pull request Jul 28, 2021
Merged
marsishandsome added a commit that referenced this pull request Jul 28, 2021
@marsishandsome
TiSession support graceful close (#238) (#244)
7ce6c4d 
Signed-off-by: marsishandsome <marsishandsome@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@birdstorm birdstorm birdstorm approved these changes

@Little-Wallace Little-Wallace Awaiting requested review from Little-Wallace

Assignees
No one assigned
Labels
status/LGT1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@marsishandsome @ti-srebot @birdstorm