Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: txn ingest #254

Merged
merged 2 commits into from
Aug 20, 2021
Merged

feat: txn ingest #254

merged 2 commits into from
Aug 20, 2021

Conversation

Abingcbc
Copy link
Contributor

@Abingcbc Abingcbc commented Aug 11, 2021 •
edited

What problem does this PR solve?

Txn ingest for java client

What is changed and how it works?

  1. Enhance ImporterStoreClient for txn-write grpc method.
  2. Enhance ImportClient to write sst and ingest in txn mode.
  3. KVClient provides method ingest for users.

Check List

Tests

  • Unit test

Code changes

  • Has exported function/method change

Side effects

Related changes

@marsishandsome
Copy link
Collaborator

/run-all-tests

2 similar comments
@Abingcbc
Copy link
Contributor Author

/run-all-tests

@marsishandsome
Copy link
Collaborator

/run-all-tests

@Abingcbc
Copy link
Contributor Author

/run-all-tests

@marsishandsome
Copy link
Collaborator

/run-all-tests

@Abingcbc
Copy link
Contributor Author

/run-all-tests

2 similar comments
@Abingcbc
Copy link
Contributor Author

/run-all-tests

@Abingcbc
Copy link
Contributor Author

/run-all-tests

@Abingcbc
feat: txn ingest
c58ece7 
Signed-off-by: abingcbc <abingcbc626@gmail.com>
@Abingcbc
refactor: merge TxnImporterClient into Importerclient
7fa706a 
Signed-off-by: abingcbc <abingcbc626@gmail.com>
@Abingcbc
Copy link
Contributor Author

/run-all-tests

@Abingcbc Abingcbc mentioned this pull request Aug 20, 2021
Open
5 tasks
marsishandsome
marsishandsome approved these changes Aug 20, 2021
View reviewed changes
Copy link
Collaborator

@marsishandsome marsishandsome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marsishandsome marsishandsome merged commit e5be356 into tikv:master Aug 20, 2021
@marsishandsome marsishandsome mentioned this pull request Aug 23, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marsishandsome marsishandsome marsishandsome approved these changes

Assignees
No one assigned
Labels
status/LGT1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Abingcbc @marsishandsome @ti-srebot