Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bulk load: support deduplicate key #276

Merged
merged 1 commit into from
Sep 14, 2021
Merged

bulk load: support deduplicate key #276

merged 1 commit into from
Sep 14, 2021

Conversation

marsishandsome
Copy link
Collaborator

Signed-off-by: marsishandsome marsishandsome@gmail.com

What problem does this PR solve?

tikv/migration#30

bulk load: support deduplicate key

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation
  • Need to be included in the release note

@marsishandsome
bulk load: support deduplicate key
c73aaf8 
Signed-off-by: marsishandsome <marsishandsome@gmail.com>
@marsishandsome
Copy link
Collaborator Author

/run-all-tests

Little-Wallace
Little-Wallace approved these changes Sep 14, 2021
View reviewed changes
Copy link
Contributor

@Little-Wallace Little-Wallace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marsishandsome
Copy link
Collaborator Author

/run-all-tests

@marsishandsome marsishandsome mentioned this pull request Sep 14, 2021
Merged
@marsishandsome marsishandsome merged commit 5e9d65e into tikv:master Sep 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Little-Wallace Little-Wallace Little-Wallace approved these changes

Assignees
No one assigned
Labels
status/LGT1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@marsishandsome @Little-Wallace @ti-srebot