support APIVersion in BackupMeta #287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marsishandsome
force-pushed
the
feature/br-add-api-version
branch
2 times, most recently
from
df40f70
to
cf2e561
Compare
|
/run-all-tests |
Signed-off-by: marsishandsome <marsishandsome@gmail.com>
marsishandsome
force-pushed
the
feature/br-add-api-version
branch
from
cf2e561
to
aa6e4eb
Compare
marsishandsome
changed the title
|
/run-all-tests |
andylokandy
reviewed
Oct 23, 2021
| if (backupMeta.getIsRawKv()) { | ||
| // TODO: ttl_enable should be witten to BackupMeta | ||
| return new RawKVDecoderV1(ttlEnabled); | ||
| if ("V1".equals(backupMeta.getApiVersion().name())) { |
There was a problem hiding this comment.
What if the api version in the backup meta is V1ttl?
There was a problem hiding this comment.
for V1 mode, the parameter ttl is designed to be passed by parameter.
not stored in the backup meta.
Cause it will be replaced by API V2 soon, so we simply do not store ttl in backup meta.
andylokandy
approved these changes
Oct 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: marsishandsome marsishandsome@gmail.com
What problem does this PR solve?
issue: pingcap/tidb#28823
when decoding SST files generated by
br backup, we should know:api versionthe decoding metho depends on it.
What is changed and how it works?
Check List
Tests
Code changes
Side effects
Related changes