Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix unclosed Thread when create TiSession error #300

Merged
merged 1 commit into from
Oct 28, 2021
Merged

fix unclosed Thread when create TiSession error #300

merged 1 commit into from
Oct 28, 2021

Conversation

marsishandsome
Copy link
Collaborator

Signed-off-by: marsishandsome marsishandsome@gmail.com

What problem does this PR solve?

If the metrics HTTP port is not free, TiSession will leave a unclosed Thread in PDClient.

What is changed and how it works?

put MetricsServer.getInstance at the beginning of this function to avoid unclosed Thread

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation
  • Need to be included in the release note

@marsishandsome
fix unclosed Thread when create TiSession error
36c1afe 
Signed-off-by: marsishandsome <marsishandsome@gmail.com>
@marsishandsome
Copy link
Collaborator Author

/run-all-tests

birdstorm
birdstorm approved these changes Oct 28, 2021
View reviewed changes
Copy link
Collaborator

@birdstorm birdstorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marsishandsome marsishandsome merged commit 489e5c2 into tikv:master Oct 28, 2021
ti-srebot pushed a commit to ti-srebot/client-java that referenced this pull request Oct 28, 2021
@marsishandsome @ti-srebot
cherry pick tikv#300 to release-3.1
837a0a3 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Oct 28, 2021
Merged
@ti-srebot
Copy link
Collaborator

cherry pick to release-3.1 in PR #301

marsishandsome added a commit that referenced this pull request Oct 28, 2021
@ti-srebot @marsishandsome
fix unclosed Thread when create TiSession error (#300) #301
db2073d 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: Liangliang Gu <marsishandsome@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@birdstorm birdstorm birdstorm approved these changes

Assignees
No one assigned
Labels
status/LGT1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@marsishandsome @ti-srebot @birdstorm