metrics: enrich grafana panel #322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: iosmanthus <myosmanthustree@gmail.com>
Signed-off-by: iosmanthus <myosmanthustree@gmail.com>
|
@marsishandsome PTAL |
birdstorm
approved these changes
Nov 12, 2021
| @@ -174,7 +197,7 @@ | |||
| "steppedLine": false, | |||
| "targets": [ | |||
| { | |||
| "expr": "sum(rate(client_java_raw_requests_latency_sum[1m])) by (type) / sum(rate(client_java_raw_requests_latency_count[1m])) by (type)", | |||
| "expr": "sum(rate(client_java_raw_requests_failure_total[1m])) by (type)", | |||
There was a problem hiding this comment.
how about we change the left-axis scale of all graphs containing xxx latency from linear to log (base 10)?
There was a problem hiding this comment.
Just out of curiosity, why do we need the log scale instead of linear? Linear may more is intuitive to me.
ti-srebot
approved these changes
Nov 15, 2021
ti-srebot
pushed a commit
to ti-srebot/client-java
that referenced
this pull request
Nov 15, 2021
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
cherry pick to release-3.1 in PR #326 |
marsishandsome
pushed a commit
that referenced
this pull request
Nov 15, 2021
Signed-off-by: ti-srebot <ti-srebot@pingcap.com> Co-authored-by: iosmanthus <dengliming@pingcap.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: iosmanthus myosmanthustree@gmail.com
What problem does this PR solve?
Add more grafana panels, which are maps to the existing metrics.
What is changed and how it works?
Check List
Tests
Code changes
Side effects
Related changes