refactor getRegionStoreClientBuilder to improve readability #349
+13
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jian Zhang <zjsariel@gmail.com>
ti-srebot
approved these changes
Nov 29, 2021
|
/merge |
|
Your auto merge job has been accepted, waiting for:
|
|
/run-all-tests |
ankita25
pushed a commit
to ankita25/client-java
that referenced
this pull request
Dec 14, 2021
Signed-off-by: Jian Zhang <zjsariel@gmail.com> Signed-off-by: Ankita Wagh <awagh@pinterest.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jian Zhang zjsariel@gmail.com
What problem does this PR solve?
improve readability
What is changed and how it works?
getRegionStoreClientBuilderto reduce code indentgetRegionStoreClientBuilderto createRawKVClientandKVClientCheck List
Tests