Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

log SlowLog if error occures #361

Merged
merged 1 commit into from
Dec 6, 2021

Conversation

marsishandsome
Copy link
Collaborator

@marsishandsome marsishandsome commented Dec 6, 2021

Signed-off-by: marsishandsome marsishandsome@gmail.com

close #362

Currently TiKV will only log SlowLog if slowThresholdMS exceeds.

Besides TiKV should also log SlowLog if error occures.

@marsishandsome
Copy link
Collaborator Author

/run-all-tests

Signed-off-by: marsishandsome <marsishandsome@gmail.com>
@marsishandsome
Copy link
Collaborator Author

/run-all-tests

Copy link
Member

@iosmanthus iosmanthus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marsishandsome
Copy link
Collaborator Author

@birdstorm @zz-jason PTAL

Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason merged commit f12d19d into tikv:master Dec 6, 2021
ti-srebot pushed a commit to ti-srebot/client-java that referenced this pull request Dec 6, 2021
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Collaborator

cherry pick to release-3.1 in PR #363

zz-jason pushed a commit that referenced this pull request Dec 6, 2021
ankita25 pushed a commit to ankita25/client-java that referenced this pull request Dec 14, 2021
Signed-off-by: Ankita Wagh <awagh@pinterest.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

log SlowLog if error occures
4 participants