Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[close #375] warm up SmartRawKVClient while creating it #376

Merged

Conversation

iosmanthus
Copy link
Member

Signed-off-by: iosmanthus myosmanthustree@gmail.com

What problem does this PR solve?

We find some initialization work that needs to do in the first gRPC call in SmartRawKVClient which might result in a timeout in the first few gRPC calls.

First run:

image

Second run:

image

What is changed and how it works?

To solve this problem, we may launch a raw_get request to warm up the runtime.

Signed-off-by: iosmanthus <myosmanthustree@gmail.com>
Signed-off-by: iosmanthus <myosmanthustree@gmail.com>
Copy link
Collaborator

@marsishandsome marsishandsome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason changed the title warm up SmartRawKVClient while creating it [close #375] warm up SmartRawKVClient while creating it Dec 9, 2021
@zz-jason zz-jason merged commit 8dcd2c1 into tikv:master Dec 9, 2021
ti-srebot pushed a commit to ti-srebot/client-java that referenced this pull request Dec 9, 2021
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Collaborator

cherry pick to release-3.1 in PR #377

ankita25 pushed a commit to ankita25/client-java that referenced this pull request Dec 14, 2021
Signed-off-by: Ankita Wagh <awagh@pinterest.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants