Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix #389] move CircuitBreaker to TiSession #390

Merged
merged 1 commit into from
Dec 11, 2021
Merged

[fix #389] move CircuitBreaker to TiSession #390

merged 1 commit into from
Dec 11, 2021

Conversation

zz-jason
Copy link
Member

@zz-jason zz-jason commented Dec 11, 2021 •
edited

Signed-off-by: Jian Zhang zjsariel@gmail.com

What problem does this PR solve?

What is changed and how it works?

make CircuitBreaker been created for every TiSession instead of every SmartRawKVClient

Check List

Tests

  • Unit test

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation
  • Need to be included in the release note

@zz-jason
[fix tikv#389] move CircuitBreaker to TiSession
0c71bc4 
Signed-off-by: Jian Zhang <zjsariel@gmail.com>
sunxiaoguang
sunxiaoguang approved these changes Dec 11, 2021
View reviewed changes
Copy link
Member

@sunxiaoguang sunxiaoguang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

marsishandsome
marsishandsome approved these changes Dec 11, 2021
View reviewed changes
Copy link
Collaborator

@marsishandsome marsishandsome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason merged commit faf1da7 into tikv:master Dec 11, 2021
@marsishandsome
Copy link
Collaborator

/merge

@zz-jason zz-jason deleted the bugfix/CircuitBreaker branch December 11, 2021 12:06
ti-srebot pushed a commit to ti-srebot/client-java that referenced this pull request Dec 11, 2021
@zz-jason @ti-srebot
cherry pick tikv#390 to release-3.1
1fa267d 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Dec 11, 2021
Merged
@ti-srebot
Copy link
Collaborator

cherry pick to release-3.1 in PR #391

marsishandsome pushed a commit that referenced this pull request Dec 11, 2021
@ti-srebot
[fix #389] move CircuitBreaker to TiSession (#390) (#391)
83fb5f4 
* cherry pick #390 to release-3.1
Co-authored-by: Jian Zhang <zjsariel@gmail.com>
Co-authored-by: Liangliang Gu <marsishandsome@gmail.com>
ankita25 pushed a commit to ankita25/client-java that referenced this pull request Dec 14, 2021
@zz-jason @ankita25
[fix tikv#389] move CircuitBreaker to TiSession (tikv#390)
79c6b13 
Signed-off-by: Ankita Wagh <awagh@pinterest.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sunxiaoguang sunxiaoguang sunxiaoguang approved these changes

@marsishandsome marsishandsome marsishandsome approved these changes

@ti-srebot ti-srebot ti-srebot approved these changes

Assignees
No one assigned
Labels
component/common component/rawkv status/can-merge status/LGT2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] java.lang.OutOfMemoryError: unable to create new native thread
4 participants
@zz-jason @marsishandsome @ti-srebot @sunxiaoguang