[close #404] use System.nanoTime() to calculate duration, cause System.currentTimeMillis() is not monotonic #402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marsishandsome
changed the title
|
/run-all-tests |
zz-jason
reviewed
Dec 14, 2021
zz-jason
reviewed
Dec 14, 2021
birdstorm
reviewed
Dec 15, 2021
| this.endMS = 0; | ||
| this.endNano = 0; | ||
| } | ||
|
|
||
| @Override | ||
| public void start() { | ||
| this.startMS = System.currentTimeMillis(); |
There was a problem hiding this comment.
I think we can remove the previous startMS and switch to nanoTime
There was a problem hiding this comment.
we will lose the time point information if removed.
System.nanoTime() can be only used to measure the difference of time.
There was a problem hiding this comment.
how about we use a specialized clock to calculate the difference of time more accurately without checking currentMillis() every time? I can optimize it after your PR is merged.
…Millis() is not monotonic Signed-off-by: marsishandsome <marsishandsome@gmail.com>
marsishandsome
force-pushed
the
feature/use-system-nanoTime
branch
from
9d8a01c
to
4136353
Compare
Signed-off-by: marsishandsome <marsishandsome@gmail.com>
marsishandsome
force-pushed
the
feature/use-system-nanoTime
branch
from
4136353
to
d784297
Compare
Signed-off-by: marsishandsome <marsishandsome@gmail.com>
Signed-off-by: marsishandsome <marsishandsome@gmail.com>
marsishandsome
force-pushed
the
feature/use-system-nanoTime
branch
from
9121280
to
d04f417
Compare
iosmanthus
reviewed
Dec 15, 2021
Signed-off-by: marsishandsome <marsishandsome@gmail.com>
zz-jason
reviewed
Dec 15, 2021
Signed-off-by: marsishandsome <marsishandsome@gmail.com>
marsishandsome
force-pushed
the
feature/use-system-nanoTime
branch
from
a7c5c90
to
1edf58b
Compare
ti-srebot
approved these changes
Dec 15, 2021
|
/merge |
|
/run-all-tests |
|
@marsishandsome merge failed. |
|
@marsishandsome UT failed, PTAL: |
|
/run-all-tests |
ti-srebot
pushed a commit
to ti-srebot/client-java
that referenced
this pull request
Dec 17, 2021
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
cherry pick to release-3.1 in PR #417 |
marsishandsome
added a commit
that referenced
this pull request
Dec 17, 2021
Signed-off-by: ti-srebot <ti-srebot@pingcap.com> Co-authored-by: Liangliang Gu <marsishandsome@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: marsishandsome marsishandsome@gmail.com
close #404
use System.nanoTime() to calculate duration, cause System.currentTimeMillis() is not monotonic
The performance between
System.nanoTime()andSystem.currentTimeMillis()is almost the same.see https://www.javaadvent.com/2019/12/measuring-time-from-java-to-kernel-and-back.html